s

bot/services/mikopbx_service.py

@@ -129,22 +129,55 @@ class MikoPBXService:
                 "error": error
             }
 
+    async def get_employee_by_number(self, number: str) -> Optional[Dict]:
+        """Get employee record by extension number (returns full record with real 'id')"""
+        # Get list and search by number
+        response = await self._make_request("GET", "/pbxcore/api/v3/employees")
+        if not response.get("result"):
+            return None
+
+        employees = response.get("data", [])
+        for emp in employees:
+            if isinstance(emp, dict) and emp.get("number") == number:
+                return emp
+        return None
+
     async def get_extension(self, number: str) -> Optional[Dict]:
         """Get employee by number"""
-        response = await self._make_request("GET", f"/pbxcore/api/v3/employees/{number}")
-        return response.get("data") if response.get("result") else None
+        return await self.get_employee_by_number(number)
 
     async def set_extension_secret(self, number: str, new_secret: str) -> Dict[str, Any]:
-        current = await self.get_extension(number)
+        current = await self.get_employee_by_number(number)
         if not current:
             return {"success": False, "error": "Extension not found"}
+
+        real_id = current.get("id")
         current["sip_secret"] = new_secret
-        response = await self._make_request("PUT", f"/pbxcore/api/v3/employees/{number}", json_data=current)
+
+        response = await self._make_request(
+            "PUT", 
+            f"/pbxcore/api/v3/employees/{real_id}", 
+            json_data=current
+        )
         return {"success": response.get("result", False), "messages": response.get("messages", [])}
 
     async def delete_extension(self, number: str) -> Dict[str, Any]:
-        response = await self._make_request("DELETE", f"/pbxcore/api/v3/employees/{number}")
-        return {"success": response.get("result", False), "messages": response.get("messages", [])}
+        """Delete employee by extension number (finds real ID first)"""
+        employee = await self.get_employee_by_number(number)
+        if not employee:
+            return {"success": False, "error": "Employee not found"}
+
+        real_id = employee.get("id")
+        logger.info(f">>> Deleting employee with real ID: {real_id}")
+
+        response = await self._make_request(
+            "DELETE", 
+            f"/pbxcore/api/v3/employees/{real_id}"
+        )
+        return {
+            "success": response.get("result", False), 
+            "messages": response.get("messages", [])
+        }
 
     async def close(self):
         if self.session: